Skip to Content.
Sympa Menu

sphenix-software-l - Re: [Sphenix-software-l] OFFLINE_MAIN is not setup correctly by bash setup script

sphenix-software-l AT lists.bnl.gov

Subject: sPHENIX discussion of software

List archive

Chronological Thread  
  • From: pinkenburg <pinkenburg AT bnl.gov>
  • To: sphenix-software-l AT lists.bnl.gov
  • Subject: Re: [Sphenix-software-l] OFFLINE_MAIN is not setup correctly by bash setup script
  • Date: Fri, 20 Dec 2019 15:26:34 -0500

Hi Bing,

sorry, that one was a victim of the straightening out of our OSG cvmfs volumes which had sphenix.sdcc.bnl.gov in a lot of configuration and text files. I put the previous version in place and will modify the copy scripts to leave this one alone. I just triggered the release - in 15 minutes it should work again.

Sorry about that

Chris

P.S. Good catch with the force_base, if that had happened that would have been really hard to debug , that's also fixed by now


On 12/19/2019 9:07 PM, bxia wrote:
Hi, software administrators and bash users,

Today I found OFFLINE_MAIN was not set up correctly after sourcing /opt/sphenix/core/bin/sphenix_setup.sh. So I took a look into this script, and one line caught my attention. In Line 130, this test goes into the "else" cluase in today's environment setting. I know little about sPHENIX directory structure, so I'm not sure if this is the intension of this script. But this bahavior is a little tricky when the variable is not set or empty (I mean a string of zero length) in the test. It's worthy a mention. According to bash's manpage, this result should be the same as the non-POSIX [[ ]], but these two give different results. I know bash's behavior changes with versions sometimes, so this test might have behaved differently in previous version.

Also, I found a bug which is irrelavent to this issue. Line 59 tries to get the base directory set by users, however this should be placed inside the case when -b is given. If not, by the end of the day, we get "ne" in Line 3 when -b is not set by users. If there is a directory "ne" in the current directory by change (usually it is our home directory), the bug will surface at the test in Line 134.

Thank you for taking time for this and for providing an official bash setup script.

Bing
_______________________________________________
sPHENIX-software-l mailing list
sPHENIX-software-l AT lists.bnl.gov
https://lists.bnl.gov/mailman/listinfo/sphenix-software-l

--
*************************************************************

Christopher H. Pinkenburg ; pinkenburg AT bnl.gov
; http://www.phenix.bnl.gov/~pinkenbu

Brookhaven National Laboratory ; phone: (631) 344-5692
Physics Department Bldg 510 C ; fax: (631) 344-3253
Upton, NY 11973-5000

*************************************************************





Archive powered by MHonArc 2.6.24.

Top of Page