FWD Software

[David Kapukchyan <dkapu001 AT ucr.edu>]

Hello,

     Kumar and I spent a good deal of time on this. I documented this as an issue on github here https://github.com/star-bnl/star-sw/issues/706. There I explain the root cause of the problem and moving headers does not really solve the problem if you don't understand what is actually happening behind the scenes. Once you understand what is happening there are multiple solutions all of which become irrelevant once the software has been integrated with STAR. Essentially, it is happening because cons gets confused about dependencies when building new software on pre-existing software. Please take a look before making any pull requests. I am happy to discuss it in more detail as well.

                 Best,

                     David

PS: I apologize if I was not more forthcoming about this issue, but I didn't realize so many people would need such a fix and that this ad hoc solution would propagate so quickly.

On Sat, Sep 28, 2024 at 9:55 AM Gavin Wilks <gwilks3 AT uic.edu> wrote:

Hello Barak, 

Thank you for the quick response and this solution. 

Gavin

On Sep 28, 2024, at 11:43, Barak Schmookler <baraks AT ucr.edu> wrote:

Hi Gavin,

We saw that as well when trying to compile on SDCC. Kumar helped me get around the issue by adjusting the order of the headers being included in StEventHelper.cxx.

See here: https://github.com/bschmookler/star-sw-1/commit/3acaf8c9cc47919546213e736c636462b0a4aa32

Daniel, if you think this is a good solution, I can make a PR into your dev branch.

Best,

Barak

On Sat, Sep 28, 2024 at 11:19 AM Gavin Wilks <gwilks3 AT uic.edu> wrote:

Hello All,

I believe someone mentioned having an issue with the parameter “kFwdVtxId” at our last meeting. I am unable to compile the code without receiving the following error:

```

.sl73_gcc485/include/StVertex.h: In member function 'virtual void StVertex::setFwdVertex()':

.sl73_gcc485/include/StVertex.h:131:53: error: 'kFwdVtxId' was not declared in this scope

     virtual void setFwdVertex()       {SETBIT(mFlag,kFwdVtxId);}

                                                     ^

/cvmfs/star.sdcc.bnl.gov/star-spack/spack/opt/spack/linux-rhel7-x86/gcc-4.8.5/root-5.34.38-llsepmmfuwlsucogcwbjiodncxanoudt/include/Rtypes.h:166:32: note: in definition of macro 'BIT'

 #define BIT(n)       (1ULL << (n))

                                ^

.sl73_gcc485/include/StVertex.h:131:40: note: in expansion of macro 'SETBIT'

     virtual void setFwdVertex()       {SETBIT(mFlag,kFwdVtxId);}

                                        ^

.sl73_gcc485/include/StVertex.h: In member function 'bool StVertex::isFwdVtx() const':

.sl73_gcc485/include/StVertex.h:139:65: error: 'kFwdVtxId' was not declared in this scope

     bool        isFwdVtx()          const {return TESTBIT(mFlag,kFwdVtxId);}

                                                                 ^

/cvmfs/star.sdcc.bnl.gov/star-spack/spack/opt/spack/linux-rhel7-x86/gcc-4.8.5/root-5.34.38-llsepmmfuwlsucogcwbjiodncxanoudt/include/Rtypes.h:166:32: note: in definition of macro 'BIT'

 #define BIT(n)       (1ULL << (n))

                                ^

.sl73_gcc485/include/StVertex.h:139:51: note: in expansion of macro 'TESTBIT'

     bool        isFwdVtx()          const {return TESTBIT(mFlag,kFwdVtxId);}

                                                   ^

cons: *** [.sl73_gcc485/obj/StRoot/StEventUtilities/StEventHelper.o] Error 1

cons: errors constructing .sl73_gcc485/obj/StRoot/StEventUtilities/StEventHelper.o

```

I have checked StRoot/StEvent/StEnumerations.h where this parameter is defined and I do not see any issue. Has anyone had this problem and found a solution to this?

Best,

Gavin