Star-fst-l mailing list

[Daniel Brandenburg <dbrandenburg.ufl AT gmail.com>]

Hi Zhenyu,

Thanks for the feedback.

I am talking about StFstRawHitMaker and all StFst*Collection classes, and everything else under StEvent.

Best,

Daniel

On Fri, Oct 22, 2021, 10:51 PM Zhenyu Ye <yezhenyu2003 AT gmail.com> wrote:

Hi Daniel, 

On Oct 22, 2021, at 11:59 AM, Daniel Brandenburg <dbrandenburg.ufl AT gmail.com> wrote:

Dear Shenghui,

Thanks for posting the slides and the code.

I will comment on the points Flemming brought up shortly. 

For now I'd like to know (from you) the status of the raw data reader and the StEvent code. Last I heard it was essentially ready.

What do you mean by raw data reader, and StEvent code? Please use the name of the code in Shenghui’s slides.

Specifically, I need to understand better how the pedestal and CMN subtraction are done. My suggestion is to save all raw data so that we can later recompute corrections, mapping, etc. as we improve the offline software later on. Are we setup for that initial step and if not what else is needed?

Yes, this is our plan as described in the FST commissioning plan by Xu. We would like to start the data taking with saving all the raw data (no-ZS) in pedestal or cosmic run, to adjust the online ZS thresholds and validate online pedestal and CMN correction. Let me know what you mean by recompute mapping, and what other (etc) you have in mind.

I'd like to be ready to put in the pull requests on the StEvent, raw data reader and initial chain option by Tuesday next week.

Please be more specific about which codes you have in mind, using the codes listed in Shenghui’s slide, and we can let you know the status and plan.

Best,

Zhenyu

Best,

Daniel

On Thu, Oct 21, 2021 at 6:58 PM videbaek <videbaek AT bnl.gov> wrote:

Hi Shenghui,

Thanks for posting the slides and all the work that went into this.
Some of the code snippets are hard to read from slides though.

I have a couple of comments/questions:

i) Open questions:
--- The Topo map is used for mid-rapidity tracking and is not relevant 
for FST,sTGC and FCS.
     There maybe a need for something similar for the forward tracking. 
Daniel?
     ome of the other Ist related stuff may be for mi-d-rapidity 
tracking.
ii) slide 7
     How are this calculations and tables related to what is implemented 
for the DAQ code? The DAQ code needs this info right away
and this cannot be redone later (pedestal, CMN etc) except for a subset 
of events. This was done for IST in the late stages, but is planed to be
done online for FST. I think this needs some discussion.
iii) It would be good to have a writeup on definitions of the coordinate 
transformations that are needed. I know its being implemented in
the geometry descriptions, but it has to be used in the HitMakers and 
should be well understood. You say the calibrationMakecreated the CMN 
data, but thats too late. as it's applied in the online DAQ. How is this 
coordinated?
iv) I think som more thought should go into marking bad channels , apv 
chips as this is already need for online. We shoud not have two diffrent 
sources for this.
) StFstHit
-- looks ok if one chekcs what's already in StHit; It would be usefull 
in the comments to define units, and precise definitions.E.g. the is
    a size in Z directions (units ..) . I guess this comes from 
segmentation in 4 radial segments of the sensors not Z which is nominal 
along the beam. How is charge uncertainty evaluated. I guess one can 
read the code, but general brief descriptions will be good.

slide 11)
   - why is the collection split over sensors. I would guess you need to 
access it on a per wedge(or mybe even ring)  when matching hits, but 
this
     of course depends how genfit wants the hits presented.The data 
structure layout should math what is needed in tracking, and it may be 
different
   for the forward tracking than for mid-rapidity with HFT.


best Flemming



On 2021-10-20 05:01, Zhang, Shenghui wrote:
> Hi all,
> 
>  Please find the detailed information of FST offline software below:
>  
> https://drupal.star.bnl.gov/STAR/system/files/FST_Software_Status_10202021.pdf
> 
>  Any comments, suggetions or questions?
> 
>  The codes have been uploded to RCF:
>  /star/u/shenghui/shenghui/FST/offline/StRoot/
> 
>  Best,
>  Shenghui
> _______________________________________________
> Star-fst-l mailing list
> Star-fst-l AT lists.bnl.gov
> https://lists.bnl.gov/mailman/listinfo/star-fst-l

-- 
Flemming Videbaek
senior scientist
videbaek @ bnl.gov
Brookhaven National Lab
Physics Department
Bldg 510D
Upton, NY 11973

phone: 631-344-4106
cell     :  631-681-1596
_______________________________________________
Star-fst-l mailing list
Star-fst-l AT lists.bnl.gov
https://lists.bnl.gov/mailman/listinfo/star-fst-l

_______________________________________________
Star-fst-l mailing list
Star-fst-l AT lists.bnl.gov
https://lists.bnl.gov/mailman/listinfo/star-fst-l