Star-tpc-l mailing list

[jwebb <jwebb AT bnl.gov>]

Hi Frank, Yuri,

The StEvent review still needs to be addressed.

1. The ClassDef macro's index should be incremented by 1 compared w/ the 
last version.
2. The GetPath function is not used anywhere and should be removed.

Jason

On 2024-09-14 16:22, Frank Geurts wrote:
> Hi Yuri, All -
>
> Thank you for clarifying. This was not particularly clear from your
> “ignored” comment.
>
> With this email (cc: TPC and S&C management group), I want to formally
> ask the TPC experts and S&C experts for the green light, or whether
> there are any fundamental issues that need to be addressed before we
> move to the creation of a dedicated library so that we can start
> calibrations and production of FXT no later than next week.
>
> Thanks,
>
>  -Frank
>
> > On Sep 13, 2024, at 10:50 AM, Fisyak, Yuri V <fisyak AT bnl.gov>
> > wrote:
> >
> > Hi Frank, thank you for explanation. Yes, it is true. I have removed
> > “OSectorAlign” because it does compete with corrections coming
> > from (new) Alignment2024.
> >
> > Yuri
> > Fisyak
> >
> > STAR                                           Phone: +1 631 344
> > 3913
> > Brookhaven National Laboratory  Fax:    +1 631 344 4206
> > 510A/1-161
> > http://www.star.bnl.gov/~fisyak       E-mail: fisyak AT bnl.gov
> >
> > From: Frank Geurts <geurts AT rice.edu>
> > Date: Friday, September 13, 2024 at 11:40 AM
> > To: Fisyak, Yuri V <fisyak AT bnl.gov>
> > Cc: Witt, Richard CIV USNA Annapolis <witt AT usna.edu>, Star-tpc L
> > <Star-tpc-l AT lists.bnl.gov>
> > Subject: Re: [[Star-tpc-l] ] Status of PR for New Alignment Library
> > Code
> >
> > Hi Yuri,
> >
> > I am referring to these particular comment that was made in the PR
> > and which appears to indicate that the CorrZ option removes the
> > OSectorAlign chain option that implements a TPC distortion
> > correction. That may be unintentional, but should  be corrected
> > unless there is an explanation.
> >
> > What may be confusing is that it doesn't explicitly pop up in the PR
> > as a change, but for CorrX, CorrY this chain option is included,
> > while for the new CorrZ it is explicitly removed (see line 1142 of
> > StRoot/StBFChain/BigFullChain.h)
> >
> > -Frank
> ________________________________________________________________________
> > Frank Geurts   (he/him)
> > Professor of Physics & Astronomy • Rice University, Houston TX
> > T.W. Bonner Nucl. Lab.          • Dept. of Physics & Astronomy
> > office 713-348-5314             • web
> https://urldefense.com/v3/__http://heavyions.rice.edu__;!!P4SdNyxKAPE!BKee6RyFZCJ1Vw7GZV33HXvl3T2FtdUReSYry6FZZIDJqnNP9dBj2zEbAqK0tWqW02WMWDwNsFrMBWo$
> > [1]
> ________________________________________________________________________
> > > On Sep 12, 2024, at 7:34 PM, Fisyak, Yuri V <fisyak AT bnl.gov>
> > wrote:
> > > Hi Frank, can you more specific on your question ? I did not
> > remove anything.
> > > In
> https://drupal.star.bnl.gov/STAR/system/files/TPC24c.Export.Mini_.pdf
> > I have not found a statement matching to your question.
> > > I have discuss alignment schema on the management meeting
> https://drupal.star.bnl.gov/STAR/system/files/Tpc%20Alignment%202024.pdf
> > and there are some references in this talk.
> > > Mathias in his presentation on the last analysis meeting
> (https://drupal.star.bnl.gov/STAR/system/files/AnalysisMeetingMathiasLabonte.pdf)
> > on Slide 18
> > > made a statement that the electric field direction is sector
> > depended.  This is the new alignment schema.
> > > Yuri
> > Fisyak
> > > STAR                                           Phone: +1 631 344
> > 3913
> > > Brookhaven National Laboratory  Fax:    +1 631 344 4206
> > > 510A/1-161
> > > http://www.star.bnl.gov/~fisyak       E-mail: fisyak AT bnl.gov
> > > From: Frank Geurts <geurts AT rice.edu>
> > > Date: Thursday, September 12, 2024 at 7:44 PM
> > > To: Witt, Richard CIV USNA Annapolis <witt AT usna.edu>, Fisyak, Yuri
> > V <fisyak AT bnl.gov>
> > > Cc: Star-tpc L <Star-tpc-l AT lists.bnl.gov>
> > > Subject: Re: [[Star-tpc-l] ] Status of PR for New Alignment
> > Library Code
> > > Thank you Richard.
> > > I have one specific question to Yuri about the removal of the TPC
> > distortion scheme (addressing E-field distortions  caused by
> > misaligned TPC sectors). From the PDF file that accompanied your PR,
> > it is not clear why this has been removed. Can you explain?
> > > -Frank
> > >
> > >
> > > On Sep 12, 2024, at 12:00 PM, Richard Witt (via star-tpc-l
> > Mailing List) <star-tpc-l AT lists.bnl.gov> wrote:
> > > Dear All,
> > > In response to a request from Frank at today’s TPC meeting,
> > here is a short summary of the status of the ongoing work to
> > incorporate the new TPC alignment for the FXT production.
> > > == The next step toward production for the FXT is the processing
> > of a sample for dE/dx calibration.
> > > == A new library, incorporating the new alignment has been
> > produced.
> > > == The S&C group must approve that library before production of
> > the calibration sample can proceed.
> > > == The S&C group needs approval of the changes made in response
> > to the current pull request associated with the new alignment code
> > before they can approve the the library for use in the calibration
> > production.
> > > ==  Due to the number of comments submitted on the PR, it is
> > unclear to the TPC group what further work is needed to receive such
> > approval or even what form that approval takes since the code will
> > not be merged when the PR is resolved (to avoid undesired effects in
> > producing older data sets).
> > > ==  The TPC group, therefore, requests a path to approval of the
> > changes made for the PR be defined so we can proceed with requesting
> > S&C approval and subsequently produce a dE/dx calibration sample
> > using the new library.
> > > Best Regards,
> > > Richard
> > > Sent from my iPad
> > > --
> > > "Education is the most powerful weapon which you can use to change
> > > the world."
> > >
> > > --Nelson Mandela
> > ~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~
> > > Richard Witt, Professor of Physics     Phone (USNA): 410-293-6675
> > > United States Naval Academy         Email: witt AT usna.edu
> > ~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~~~***~
>
>
>
> Links:
> ------
> [1] 
> https://urldefense.com/v3/__http:/heavyions.rice.edu__;!!P4SdNyxKAPE!BKee6RyFZCJ1Vw7GZV33HXvl3T2FtdUReSYry6FZZIDJqnNP9dBj2zEbAqK0tWqW02WMWDwNsFrMBWo$